implab/ImplabNet Commit - r34:dabf79fde388

fixed race condition in DispatchPool

cin -

r34:dabf79fde388 default

parent child

Context file:

r34:dabf79fde388

Implab.Test/AsyncTests.cs +1 -1

                     [TestMethod]
                     public void ChainedMapTest() {
-                        using (var pool = new WorkerPool(0,100,0)) {
+                        using (var pool = new WorkerPool(0,100,100)) {
                             int count = 10000;
                             double[] args = new double[count];

Implab.suo binary modified 0 0

NO CONTENT: modified file, binary diff hidden

Implab/Parallels/DispatchPool.cs +2 -3

                         }
                     }
-                    private void EnsurePoolIsAlive() {
+                    protected void EnsurePoolIsAlive() {
                         if (AllocateThreadSlot(1)) {
                             // if there were no threads in the pool
                             var worker = new Thread(this.Worker);
                         }
                     }
-                    private bool Suspend() {
+                    protected virtual bool Suspend() {
                         //no tasks left, exit if the thread is no longer needed
                         bool last;
                         bool requestExit;
                                 InvokeUnit(unit);
                                 continue;
                             }
                             Interlocked.Decrement(ref m_activeThreads);
                             // entering suspend state

Implab/Parallels/WorkerPool.cs +16 0

@@ -69,6 +69,22 namespace Implab.Parallels {
69	return false;	69	return false;
70	}	70	}
71		71
		72	protected override bool Suspend() {
		73	// This override solves race condition
		74	// WORKER CLIENT
		75	// ---------------------------------------
		76	// TryDeque == false
		77	// Enqueue(unit), queueLen++
		78	// GrowPool? == NO
		79	// ActiveThreads--
		80	// Suspend
		81	// queueLength > 0
		82	// continue
		83	if (m_queueLength > 0)
		84	return true;
		85	return base.Suspend();
		86	}
		87
72	protected override void InvokeUnit(Action unit) {	88	protected override void InvokeUnit(Action unit) {
73	unit();	89	unit();
74	}	90	}

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages