implab/implabjs-core Commit - r12:80e4b5709788

removed obsolete code

cin -

r12:80e4b5709788 propose cancellat...

parent child

Context file:

r12:80e4b5709788

Collapse all files

src/ts/components/ActivatableMixin.ts +4 -5

                             try {
                                 await this.onActivated(ct);
                             } catch(e) {
-                                log.error(e);
+                                log.error("Suppressed onActivated error: {0}", e);
-                                // TODO log error
                             }
                             this.completeSuccess();
                         } catch (e) {
                             this._active = false;
                             try {
                                 await this.onDeactivated(ct);
-                            } catch {
+                            } catch(e) {
-                                // TODO log error
+                                log.error("Suppressed onDeactivated error: {0}", e);
                             }
                             this.completeSuccess();
                         } catch (e) {
             }
             namespace ActivatableMixin {
+                export const traceSource = log;
             }
             export = ActivatableMixin;

src/ts/log/TraceSource.ts +32 0

                         this.emit(TraceSource.WarnLevel, format(msg, args));
                 }
+                /**
+                 * returns true if errors will be recorded.
+                 */
                 isErrorEnabled() {
                     return this.level >= TraceSource.ErrorLevel;
                 }
+                /**
+                 * Traces a error.
+                 *
+                 * @param msg the message.
+                 * @param args parameters which will be substituted in the message.
+                 */
                 error(msg: string, ...args: any[]) {
                     if (this.isEnabled(TraceSource.ErrorLevel))
                         this.emit(TraceSource.ErrorLevel, format(msg, args));
                 }
+                /**
+                 * Checks whether the specified level is enabled for this
+                 * trace source.
+                 *
+                 * @param level the trace level which should be checked.
+                 */
                 isEnabled(level: number) {
                     return (this.level >= level);
                 }
+                /**
+                 * Traces a raw event, passing data as it is to the underlying listeners
+                 *
+                 * @param level the level of the event
+                 * @param arg the data of the event, can be a simple string or any object.
+                 */
                 traceEvent(level: number, arg: any) {
                     if (this.isEnabled(level))
                         this.emit(level, arg);
                 }
+                /**
+                 * Register the specified handler to be called for every new and already
+                 * created trace source.
+                 *
+                 * @param handler the handler which will be called for each trace source
+                 */
                 static on(handler: TraceSourceHandler) {
                     return Registry.instance.on(handler);
                 }
+                /**
+                 * Creates or returns already created trace source for the specified id.
+                 *
+                 * @param id the id for the trace source
+                 */
                 static get(id: any) {
                     return Registry.instance.get(id);
                 }

test/js/plan.js +1 -1

	@@ -1,1 +1,1
	1	define(["./ActivatableTests", "./trace-test"]); No newline at end of file		1	define(["./ActivatableTests", "./trace-test", "./TraceSourceTests"]); No newline at end of file

test/ts/TraceSourceTests.ts +9 -1

             tape('', t => {
                 let trace = TraceSource.get(sourceId);
-                let h = trace.on((sender,level,msg) => {
+                trace.level = TraceSource.DebugLevel;
+                let h = trace.on((sender,level,msg) => {
+                    t.equal(sender, trace, "sender should be the current trace source");
+                    t.equal(TraceSource.DebugLevel, level, "level should be debug level");
+                    t.equal(msg, "Hello, World!", "The message should be formatted correctly");
+                    t.end();
                 });
+                trace.debug("Hello, {0}!", "World");
                 h.destroy();
             });

src/js/components/ActivationController.js removed 0 -120

NO CONTENT: file was removed

src/js/components/StateMachine.js removed 0 -34

NO CONTENT: file was removed

src/js/components/_ActivatableMixin.js removed 0 -153

NO CONTENT: file was removed

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages