implab/implabjs-djx Commit - r93:d99e2014cea4

minor code cleanups

cin -

r93:d99e2014cea4 default

parent child

Context file:

r93:d99e2014cea4

Collapse all files

djx/build.gradle +2 -2

              typescript {
                  compilerOptions {
                      lib = ["es5", "dom", "scripthost", "es2015.promise", "es2015.symbol", "es2015.iterable"]
-                     //listFiles = true
+                     // listFiles = true
                      declaration = true
                      strict = true
                      types = []
                      module = "amd"
                      it.target = "es5"
                      experimentalDecorators = true
-                     noUnusedLocals = true
+                     noUnusedLocals = false
                      jsx = "react"
                      jsxFactory = "createElement"
                      moduleResolution = "node"

djx/src/main/ts/tsx.ts +1 -1

                      key: K,
                      _descriptor: TypedPropertyDescriptor<(eventObj: EV) => void> | TypedPropertyDescriptor<() => void>
                  ): any => {
-                     const handlers = eventNames.map(eventName => ({ eventName, handlerMethod: key }))
+                     const handlers = eventNames.map(eventName => ({ eventName, handlerMethod: key }));
                      target._eventHandlers = target._eventHandlers ? target._eventHandlers.concat(handlers) : handlers;
                  };

djx/src/main/ts/tsx/HtmlRendition.ts +1 -2

                  _create(attrs: object, children: any[]) {
                      this._element = dom.create(this.elementType, attrs);
-                     if (children)
-                         children.forEach(v => this._addChild(v));
+                     children.forEach(v => this._addChild(v));
                  }
                  _getDomNode() {

djx/src/main/ts/tsx/RenditionBase.ts +5 -4

                      }
                  }
+                 /** Renders DOM element for different types of the argument. */
                  protected getItemDom(v: any) {
                      const tv = typeof v;
                          // nodes are kept as is
                          return v;
                      } else if (isRendition(v)) {
-                         // renditions as instantinated
+                         // renditions are instantiated
                          return v.getDomNode();
                      } else if (isWidget(v)) {
                          // widgets are converted to it's markup
                      }
                  }
-                 /** @deprecated will be removed in 1.0.0, use getDomNode() */
-                 getDomElement() {
-                     return this.getDomNode();
+                 /** Is rendition was instantiated to the DOM node */
+                 isCreated() {
+                     return this._created;
                  }
                  /** Creates DOM node if not created. No additional actions are taken. */

djx/src/main/ts/tsx/traits.ts +16 -12

                  } else if (isDestroyable(target)) {
                      target.destroy();
                  } else if (isNode(target)) {
-                     const w = isElementNode(target) ? registry.byNode(target) : undefined;
-                     if (w) {
-                         w.destroyRecursive();
-                     } else {
-                         registry.findWidgets(target).forEach(destroy);
-                         dom.destroy(target);
+                     if (isElementNode(target)) {
+                         const w = registry.byNode(target);
+                         if (w) {
+                             w.destroyRecursive();
+                         } else {
+                             registry.findWidgets(target).forEach(destroy);
+                             dom.destroy(target);
+                         }
                      }
                  }
              }
               */
              export function startupWidgets(target: Node | _WidgetBase, skipNode?: Node) {
                  if (isNode(target)) {
-                     const w = isElementNode(target) ? registry.byNode(target) : undefined;
-                     if (w) {
-                         if (w.startup)
-                             w.startup();
-                     } else {
-                         registry.findWidgets(target, skipNode).forEach(x => x.startup());
+                     if (isElementNode(target)) {
+                         const w = registry.byNode(target);
+                         if (w) {
+                             if (w.startup)
+                                 w.startup();
+                         } else {
+                             registry.findWidgets(target, skipNode).forEach(x => x.startup());
+                         }
                      }
                  } else {
                      if (target.startup)

djx/src/test/ts/view/MyWidget.tsx +1 -1

                  }
                  @on("count-inc")
-                 _onCounterInc(evt: Event & { detail: number; x?: number; }) {
+                 private _onCounterInc(evt: Event & { detail: number; x?: number; }) {
                  }
                  @on("click", "keydown")

djx/src/test/tsconfig.json +1 0

              {
                  "extends": "../tsconfig",
                  "compilerOptions": {
+                     "noUnusedLocals": false,
                      //"rootDir": "ts",
                      "rootDirs": [
                          "ts",

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages