implab/ImplabNet Commit - r211:3eb3255d8cc5

Code review, added a non generic version of SyncContextPromise

cin -

r211:3eb3255d8cc5 v2

parent child

Context file:

r211:3eb3255d8cc5

Collapse all files

Implab/SyncContextPromiseT.cs created 644 +18 0

@@ -0,0 +1,18
	1	using System.Threading;
	2	using System;
	3
	4	namespace Implab {
	5	public class SyncContextPromise<T> : Promise<T> {
	6	readonly SynchronizationContext m_context;
	7
	8	public SyncContextPromise(SynchronizationContext context) {
	9	Safe.ArgumentNotNull(context, "context");
	10	m_context = context;
	11	}
	12
	13	protected override void SignalHandler(HandlerDescriptor handler, int signal) {
	14	m_context.Post(x => base.SignalHandler(handler, signal), null);
	15	}
	16	}
	17	}
	18

Implab.Fx/StaApartment.cs +17 -1

                 public class StaApartment : RunnableComponent {
                     readonly Thread m_worker;
                     SynchronizationContext m_syncContext;
+                    SyncContextPromise m_enterPromise;
                     readonly Promise m_threadStarted;
                     readonly Promise m_threadTerminated;
                         }
                     }
+                    /// <summary>
+                    /// Returns the promise which will dispatch all handlers inside the apartment using it's <see cref="SynchronizationContext"/>
+                    /// </summary>
+                    /// <remarks>
+                    /// Current implementation is optimized and will lost aync operation stack
+                    /// </remarks>
+                    /// <returns>The promise</returns>
+                    public IPromise Enter() {
+                        if (m_enterPromise == null)
+                            throw new InvalidOperationException();
+                        return m_enterPromise;
+                    }
                     public IPromise Invoke(Action<ICancellationToken> action) {
                         Safe.ArgumentNotNull(action, "action");
                     void WorkerEntry() {
                         m_syncContext = new WindowsFormsSynchronizationContext();
                         SynchronizationContext.SetSynchronizationContext(m_syncContext);
+                        m_enterPromise = new SyncContextPromise(m_syncContext);
                         m_threadStarted.Resolve();
+                        m_enterPromise.Resolve();
                         Application.OleRequired();
                         Application.Run();

Implab/Implab.csproj +2 -1

                 <Compile Include="Properties\AssemblyInfo.cs" />
                 <Compile Include="Parallels\AsyncPool.cs" />
                 <Compile Include="Safe.cs" />
+                <Compile Include="SyncContextPromise.cs" />
                 <Compile Include="ValueEventArgs.cs" />
                 <Compile Include="PromiseExtensions.cs" />
-                <Compile Include="SyncContextPromise.cs" />
+                <Compile Include="SyncContextPromiseT.cs" />
                 <Compile Include="Diagnostics\OperationContext.cs" />
                 <Compile Include="Diagnostics\TraceContext.cs" />
                 <Compile Include="Diagnostics\LogEventArgs.cs" />

Implab/SyncContextPromise.cs +7 -4

-            using System.Threading;
+            using System;
-            using System;
+            using System.Collections.Generic;
+            using System.Linq;
+            using System.Text;
+            using System.Threading;
             namespace Implab {
-                public class SyncContextPromise<T> : Promise<T> {
+                public class SyncContextPromise : Promise {
                     readonly SynchronizationContext m_context;
                     public SyncContextPromise(SynchronizationContext context) {
                         Safe.ArgumentNotNull(context, "context");
                         m_context = context;
                     }
                     }
                 }
             }

General Comments 3

sergey

|

Auto status change to "Under Review"

sergey

|

ok, latest stable version should be in default

Write
Preview

You need to be logged in to leave comments. Login now

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages