implab/implabjs-djx Commit - r138:98b2c550c676

Added a fallback error handler to observables, it will report unhandled errors

cin -

r138:98b2c550c676 v1.9.0-rc3 default

parent child

Context file:

r138:98b2c550c676

Collapse all files

djx/src/main/ts/observable.ts +7 -1

+            import { id as mid} from "module";
             import { Cancellation } from "@implab/core-amd/Cancellation";
             import { ICancellation } from "@implab/core-amd/interfaces";
+            import { TraceSource } from "@implab/core-amd/log/TraceSource";
             import { isPromise } from "@implab/core-amd/safe";
+            const trace = TraceSource.get(mid);
             /**
              * The interface for the consumer of an observable sequence
              */
             const noop = () => { };
+            const errorFallback = (e: unknown) => trace.error("Unhandled observable error: {0}", e);
             const sink = <T>(consumer: Observer<T>) => {
                 const { next, error, complete } = consumer;
                 return {
                     next: next ? next.bind(consumer) : noop,
-                    error: error ? error.bind(consumer) : noop,
+                    error: error ? error.bind(consumer) : errorFallback,
                     complete: complete ? complete.bind(consumer) : noop,
                     isClosed: () => false
                 };

djx/src/main/ts/store.ts +6 -4

             import { isCancellable, isPromise } from "@implab/core-amd/safe";
             import { observe, Observable, empty } from "./observable";
             import { after } from "dojo/aspect";
-            import { subject } from "./operators/subject";
             export interface OrderedUpdate<T> {
                 /** The item is being updated */
                     observe<Change<T>>(({ next }) => {
                         const handle = after(store, "notify", (...args: Change<T>) => next(args), true);
                         return () => handle.remove();
-                    }).pipe(subject) : empty;
+                    }) : empty;
                 return (id: string | number, opts: GetOpts = {}) =>
                     observe<T>(({ next, complete, error }) => {
+                        try {
                             const result = store.get(id);
                             const handle = (x: T | null | undefined) => {
                             };
                             if (isPromise(result)) {
-                            result.then(handle, error);
+                                result.then(handle).then(undefined, error);
                                 if (isCancellable(result))
                                     return () => result.cancel();
                             } else {
                                 handle(result);
                             }
+                        } catch (e) {
+                            error(e);
+                        }
                     }).cat(opts.observe !== false ? changes.pipe(filterItem(id)) : empty);
             };

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages